Backport of chor: change cluster name param to have datacenter.name as default value into release/1.18.x #20652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/change-from-api-returned-cluster-name-to-data-center-name-on-link-to-hcp/absolutely-social-rhino
branch
from
ff0775c to
6dca41e
Compare
github-team-consul-core-pr-approver
approved these changes
Feb 15, 2024
valeriia-ruban
deleted the
backport/change-from-api-returned-cluster-name-to-data-center-name-on-link-to-hcp/absolutely-social-rhino
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20644 to be assessed for backporting due to the inclusion of the label backport/1.18.
The below text is copied from the body of the original PR.
Description
rethink on default value for cluster name on linking.
With the pr it is set to datacenter name
Attention to link ⬇️
Testing & Reproduction steps
Links
PR Checklist
Overview of commits